Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the ProjectConfig handle creating a configured analyzer and warning filter in the CLI #129

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Let the ProjectConfig handle creating a configured analyzer and warning filter in the CLI #129

merged 2 commits into from
Apr 13, 2018

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Apr 13, 2018

No description provided.

@rictic rictic requested a review from valdrinkoshi April 13, 2018 00:45
@rictic rictic mentioned this pull request Apr 13, 2018
Closed
1 task
valdrinkoshi
valdrinkoshi approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@valdrinkoshi valdrinkoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already LGTM as is :shipit:

packages/cli/src/lint/lint.ts
urlResolver,
linter,
options,
config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we pass around config but we only use config.root, would it make sense to refactor all these signatures to get the root instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time I touch this file I'm gonna refactor this into a class rather than pass these same 7-8 options around everywhere

@rictic rictic merged commit f54f6d4 into master Apr 13, 2018
@rictic rictic deleted the fixup-cli branch April 13, 2018 03:48
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdrinkoshi valdrinkoshi valdrinkoshi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rictic @valdrinkoshi @googlebot